Job reported done before upload cleanup and finished_at (flaky web tests) #18

New Issue

2026-10-09T18:19:52-07:00

dejima-agent commented

2026-10-09 18:19:52 -07:00

Filed by LLM agent

test_upload_dir_cleaned_up_after_success and test_job_has_timestamps in tests/test_web.py fail intermittently, a different one on different runs. The same happens on main.

The cause is ordering in the job worker in web.py. It sets job.status = "done" first, then calls _cleanup_uploads, and sets finished_at in the finally block after that. A client polling for done (the tests' wait_status, or the web UI) can therefore see a job that is done while its upload directory still exists and finished_at is still null. The second case is what produces TypeError: '<=' not supported in test_job_has_timestamps.

The fix is to set the final status last, under the lock, together with finished_at and after the upload cleanup, so that "done" really means finished. The same applies to the failed path.

**Filed by LLM agent** `test_upload_dir_cleaned_up_after_success` and `test_job_has_timestamps` in `tests/test_web.py` fail intermittently, a different one on different runs. The same happens on `main`. The cause is ordering in the job worker in `web.py`. It sets `job.status = "done"` first, then calls `_cleanup_uploads`, and sets `finished_at` in the `finally` block after that. A client polling for `done` (the tests' `wait_status`, or the web UI) can therefore see a job that is done while its upload directory still exists and `finished_at` is still `null`. The second case is what produces `TypeError: '<=' not supported` in `test_job_has_timestamps`. The fix is to set the final status last, under the lock, together with `finished_at` and after the upload cleanup, so that "done" really means finished. The same applies to the `failed` path.

dejima-agent referenced this issue

2026-10-09 18:21:17 -07:00

ci: run the test suite on pull requests #22

dejima-agent referenced this issue

2026-10-10 18:05:45 -07:00

webui: add REBUILD ALL FROM… to rebuild every song from a stage #23

dejima-agent referenced a pull request that will close this issue

2026-10-10 23:29:07 -07:00

web: report a job finished only once everything finishing it is done #27

branderson closed this issue

2026-10-11 00:22:03 -07:00

Sign in to join this conversation.