branderson/dotfiles
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add gitea-pr script and PR review workflow #1

Merged
branderson merged 9 commits from worktree-gitea-pr-review-workflow into master 2026-07-12 18:49:37 -07:00
Conversation 2 Commits 9 Files Changed 1
+189
branderson commented 2026-07-12 18:06:23 -07:00
Owner
Copy Link
Copy Source

Adds bin/gitea-pr (create/comments/merge against the Gitea REST API) and documents the review workflow in ~/.claude/CLAUDE.md. See ~/specs/2026-07-12-gitea-pr-review-design.md and ~/specs/2026-07-12-gitea-pr-review-plan.md for the full design/plan. All 5 tasks implemented and reviewed via subagent-driven-development; live-tested end to end against device-factory (PR #3: create, comments, merge all verified against the real server).

Adds bin/gitea-pr (create/comments/merge against the Gitea REST API) and documents the review workflow in ~/.claude/CLAUDE.md. See ~/specs/2026-07-12-gitea-pr-review-design.md and ~/specs/2026-07-12-gitea-pr-review-plan.md for the full design/plan. All 5 tasks implemented and reviewed via subagent-driven-development; live-tested end to end against device-factory (PR #3: create, comments, merge all verified against the real server).
branderson added 7 commits 2026-07-12 18:06:24 -07:00
Add gitea-pr script skeleton with host/owner/repo detection 97a631b335
Fix SC2034 warnings with narrow inline suppressions instead of loosening shellcheck invocation 933b6a3971
Split Gitea SSH host from API host (gitbox.branderson.io is HTTPS-only, gitbox.bradina.localdomain is SSH-only) c6bdd09aae
Fix silent crash in base-branch fallback when origin/HEAD symref is unset 782ba516ca
Implement gitea-pr comments a0e2dc269e
Implement gitea-pr merge 988086d9b1
Remove stale SC2034 suppressions now that GITEA_API/owner/repo are used a5bda2fd77
branderson reviewed 2026-07-12 18:24:24 -07:00
bin/gitea-pr Outdated
@@ -0,0 +2,4 @@
set -euo pipefail
GITEA_SSH_HOST="gitbox.bradina.localdomain"
GITEA_API="https://gitbox.branderson.io/api/v1"
branderson commented 2026-07-12 18:23:08 -07:00
Author
Owner
Copy Link
Copy Source

The SSH host and api should be specified outside of this script, in the environment. I'll set these in my .profile.local, just document them if this is run without these set.

The SSH host and api should be specified outside of this script, in the environment. I'll set these in my .profile.local, just document them if this is run without these set.
branderson marked this conversation as resolved
branderson added 1 commit 2026-07-12 18:35:11 -07:00
Make GITEA_SSH_HOST/GITEA_API required env vars, fetch inline review comments 6bd015fe25 
Addresses PR #1 feedback: host config should live in the environment
(~/.profile.local), not be hardcoded in the script, with a clear error
if unset. Also fixes gitea-pr comments to surface inline diff comments
from reviews, not just issue comments and top-level review bodies --
the review that requested this change would have been invisible to
gitea-pr comments without this fix.
branderson reviewed 2026-07-12 18:40:25 -07:00
bin/gitea-pr Outdated
@@ -0,0 +27,4 @@
if [ -z "${GITEA_TOKEN:-}" ]; then
echo "GITEA_TOKEN is not set. Generate a token in the Gitea web UI" \
"(Settings > Applications, scopes write:repository + write:issue)" \
"and add 'export GITEA_TOKEN=...' to ~/.profile.local" >&2
branderson commented 2026-07-12 18:40:24 -07:00
Author
Owner
Copy Link
Copy Source

We should move the GITEA token to a dedicated file so that it's not available globally in the environment, only sourced where needed.

We should move the GITEA token to a dedicated file so that it's not available globally in the environment, only sourced where needed.
branderson marked this conversation as resolved
branderson added 1 commit 2026-07-12 18:46:21 -07:00
Read Gitea token from a dedicated file instead of a global env var 7b1bae082f 
Addresses PR #1 feedback: GITEA_TOKEN shouldn't be exported globally
(visible to every process in the shell), only to gitea-pr itself.
Defaults to ~/.config/gitea/token (chmod 600); GITEA_TOKEN env var
still works as an override for one-off invocations.
branderson merged commit eec71b5f82 into master 2026-07-12 18:49:37 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
branderson
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
dejima-agent branderson
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: branderson/dotfiles#1