tests: replace copyrighted lyrics with placeholder text #14

2026-10-09T17:16:34-07:00

dejima-agent commented

2026-10-09 17:16:34 -07:00

Summary generated by LLM agent

Several tests quoted lines from published songs, and tests/fixtures/ held two complete community-made UltraStar charts of commercial songs, lyrics included. This replaces all of it with placeholder text.

Changes

test_align.py, test_transcribe.py, test_lyrics.py, test_notes.py: lyric lines are now counting words ("it's one two three" / "four five six seven eight", and so on). Every line keeps its word count, and the apostrophe, "Whoa," and "o'" tokens are kept, so the tests still check the same things.
tests/fixtures/sanctuary.txt and sweet_child.txt are replaced by two short hand-written charts. chart_crlf.txt is ASCII with CRLF endings, a decimal-comma BPM, medley headers, freestyle, golden and rap notes, and a line break with trailing spaces. chart_latin1.txt uses ISO-8859-1 bytes, which exercises the errors="replace" read, plus a negative pitch of -9 and an old two-number line break.

Not covered

The removed text is still in git history. Purging it would mean rewriting history and force-pushing main, so that's left for you to decide.

Testing

All tests touched here pass. In the full suite, test_cli.py::test_version fails only because my test environment doesn't install the package. test_web.py fails intermittently in a different test each run, and it does the same on main.

**Summary generated by LLM agent** Several tests quoted lines from published songs, and `tests/fixtures/` held two complete community-made UltraStar charts of commercial songs, lyrics included. This replaces all of it with placeholder text. ## Changes - `test_align.py`, `test_transcribe.py`, `test_lyrics.py`, `test_notes.py`: lyric lines are now counting words ("it's one two three" / "four five six seven eight", and so on). Every line keeps its word count, and the apostrophe, "Whoa," and "o'" tokens are kept, so the tests still check the same things. - `tests/fixtures/sanctuary.txt` and `sweet_child.txt` are replaced by two short hand-written charts. `chart_crlf.txt` is ASCII with CRLF endings, a decimal-comma BPM, medley headers, freestyle, golden and rap notes, and a line break with trailing spaces. `chart_latin1.txt` uses ISO-8859-1 bytes, which exercises the `errors="replace"` read, plus a negative pitch of -9 and an old two-number line break. ## Not covered The removed text is still in git history. Purging it would mean rewriting history and force-pushing `main`, so that's left for you to decide. ## Testing All tests touched here pass. In the full suite, `test_cli.py::test_version` fails only because my test environment doesn't install the package. `test_web.py` fails intermittently in a different test each run, and it does the same on `main`.

dejima-agent added 1 commit 2026-10-09 17:16:35 -07:00

tests: replace copyrighted lyrics with placeholder text 766c9f0d98

The align, transcribe, lyrics and notes tests quoted lines from published
songs, and the UltraStar parser fixtures were complete community charts of
commercial songs. Replace them with counting words and two hand-written
charts that keep what the parser tests rely on: CRLF line endings,
Latin-1 bytes, a decimal-comma BPM, freestyle/golden/rap notes, negative
pitch and a two-number line break.

branderson approved these changes 2026-10-09 18:14:49 -07:00

branderson merged commit 01f809d7ad into main

2026-10-09 18:15:02 -07:00

dejima-agent referenced this pull request

2026-10-09 18:19:58 -07:00

Decide whether to purge removed lyrics from git history #21

branderson referenced this issue from a commit

2026-10-15 14:17:08 -07:00

Merge pull request 'tests: replace copyrighted lyrics with placeholder text' (#14) from synthetic-lyrics into main

dejima-agent referenced this issue from a commit

2026-10-15 17:44:36 -07:00

Merge pull request 'tests: replace copyrighted lyrics with placeholder text' (#14) from synthetic-lyrics into main