webui: set a song's BPM and GAP from the sheet #34
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: branderson/songtrace#34
Reference in New Issue
Block a user
Summary generated by LLM agent
Stacked on #33, which is on #31 and #30. Merge from the top of the chain down: #33's chain first, then this one.
The beat grid came from the detected tempo (or the BPM override), with GAP always pinned to the first note. It didn't always line up with the music, so snapping in the editor didn't land on the song's beats. This lets BPM and GAP be set from the sheet.
The GRID bar
A strip above the toolbar:
How it's kept
edits.jsonnext to the line edits, so every rebuild keeps it, and lyric changes don't affect it. A grid set on its own keeps the file alive.tempo.jsonfor RESET.tempo.jsonexisted has its chart's BPM recorded when a grid is first set, so RESET returns to the original tempo rather than the edited one. The browser test caught that.to_ultrastarmoves it back by whole beats. That keeps the grid lines where they were set.API:
PUT /api/jobs/{id}/gridwith{bpm, gap_ms}(BPM above 0 and at most 2000, GAP 0 or more), andDELETEto reset. Both rewrite the charts in place and return the review, which now also hasgrid_editedandauto_bpm.Testing
edits: validation; the grid surviving lyric re-keying; the file kept for a grid alone.grid: explicit GAP; a late GAP moved back by whole beats with the grid kept in place; the stage using the editor's grid and recording its own.test_version(needs the package installed).The beat grid came from the detected tempo (or the BPM override) and a GAP pinned to the first note, so it did not always line up with the music, and snapping did not land on its beats. A GRID bar on the sheet now sets both, redrawing the grid live as values are tried, with x2 and /2 for a tempo detected at double or half speed and ALIGN TO NOTE to move GAP the least that puts the selected note on a beat. Note editing pauses while a trial grid is unapplied, so notes never snap to a grid that is then cancelled. The grid is stored with the song's edits, so every rebuild keeps it, and grid charts with it in place of its own choice; it records that choice in tempo.json for RESET to return to. A GAP after the first note moves back by whole beats, as notes on negative beats are rejected by players. PUT and DELETE /api/jobs/{id}/grid set and reset it, rewriting the charts in place.Line breaks were always placed by songtrace, midway between lines and recomputed around edited ones, so a break could not be put where a singer breathes. The sheet now draws the breaks either side of a line as markers that drag along the beat grid, kept between the lines they separate, and double-click back to automatic. Break moves share the line's undo history and SAVE LINE, which saves the notes only if they changed, so moving a break never locks either line's notes. Moved breaks are stored in edits.json keyed by the line each comes before, follow their lines when the lyrics change, and win over the computed break on every rebuild, clamped so a break never lands inside a line's notes. The review lists each break with that line and whether it was moved, and PUT /api/jobs/{id}/breaks takes {line: seconds | null}. merge now passes untouched notes through as they are rather than rebuilding them, which added float noise to their durations.