webui: edit a song's notes on the sheet #31
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: branderson/songtrace#31
Reference in New Issue
Block a user
Summary generated by LLM agent
Stacked on #30: it targets that PR's branch so this diff is only the editing. Merge #30 first.
Phase 2, part 2: the note sheet becomes an editor. Lines are saved through the edits API from #29, so every edit survives rebuilds, REBUILD ALL FROM… included.
Editing
~), M merges with the next note (a held~adds no text), G/F/R toggle golden, freestyle and rap.PUT /api/jobs/{id}/lines/{n}, which rewrites the work and packaged charts in place. REVERT returns a line to the generated notes, and DISCARD drops unsaved changes.Not losing work
An UNSAVED badge shows while a line has unsaved changes. Paging away, switching songs or pressing CREATE SONG asks first. Playback won't page the sheet away from a line with unsaved changes. Closing the tab warns.
Code
static/edit-model.jsholds every operation as a pure function over a line's notes: snap, move, resize, stretch, split, merge, insert, remove, kinds, text, saving, and the undo history. Unit-tested withnode --test(12 tests intests/js/edit-model.test.mjs).sheet.jshandles input and drawing. It hit-tests notes by geometry (time span and pitch row) instead of the event target. The first version used the target, and a render that replaced the element under the pointer cost the sheet its keyboard focus and broke double-click. The window and pitch range stay fixed during a drag, so rows don't jump under the pointer, and only grow afterwards.index.htmladds the play-line stop, refreshes the lyric list after a save, and asks before discarding unsaved changes. The new guard on CREATE SONG sits before the existing form guard, so the guard-removal tests intest_web.pystill find their anchor.Testing
All with a synthetic counting-words song on a seeded local server, driven in Chromium:
edited: true.Full suite passes, except
test_version(needs the package installed). The Node tests run through pytest.The README gains an "Editing a song" section. Its screenshot still isn't regenerated, because
scripts/screenshot_webui.pyneeds Python Playwright and this sandbox has only the Node one. I can port that script to Node in a follow-up.The beat grid came from the detected tempo (or the BPM override) and a GAP pinned to the first note, so it did not always line up with the music, and snapping did not land on its beats. A GRID bar on the sheet now sets both, redrawing the grid live as values are tried, with x2 and /2 for a tempo detected at double or half speed and ALIGN TO NOTE to move GAP the least that puts the selected note on a beat. Note editing pauses while a trial grid is unapplied, so notes never snap to a grid that is then cancelled. The grid is stored with the song's edits, so every rebuild keeps it, and grid charts with it in place of its own choice; it records that choice in tempo.json for RESET to return to. A GAP after the first note moves back by whole beats, as notes on negative beats are rejected by players. PUT and DELETE /api/jobs/{id}/grid set and reset it, rewriting the charts in place.Line breaks were always placed by songtrace, midway between lines and recomputed around edited ones, so a break could not be put where a singer breathes. The sheet now draws the breaks either side of a line as markers that drag along the beat grid, kept between the lines they separate, and double-click back to automatic. Break moves share the line's undo history and SAVE LINE, which saves the notes only if they changed, so moving a break never locks either line's notes. Moved breaks are stored in edits.json keyed by the line each comes before, follow their lines when the lyrics change, and win over the computed break on every rebuild, clamped so a break never lands inside a line's notes. The review lists each break with that line and whether it was moved, and PUT /api/jobs/{id}/breaks takes {line: seconds | null}. merge now passes untouched notes through as they are rather than rebuilding them, which added float noise to their durations.9bf323b740to5877e35bfa